Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdw-login should probably be started by a systemd unit instead of autostart entry #1073

Open
1 task done
legoktm opened this issue Jun 6, 2024 · 1 comment · May be fixed by #1086
Open
1 task done

sdw-login should probably be started by a systemd unit instead of autostart entry #1073

legoktm opened this issue Jun 6, 2024 · 1 comment · May be fixed by #1086
Assignees
@rocodes

Comments

@legoktm
Copy link
Member

legoktm commented Jun 6, 2024

  • I have searched for duplicates or related issues

Description

sdw-login is currently started by an autostart entry:

securedrop-workstation/securedrop_salt/sd-dom0-files.sls

Lines 66 to 79 in 95da570

dom0-login-autostart-desktop-file:
file.managed:
- name: /home/{{ gui_user }}/.config/autostart/press.freedom.SecureDropUpdater.desktop
- source: "salt://securedrop_salt/dom0-xfce-desktop-file.j2"
- template: jinja
- context:
desktop_name: SDWLogin
desktop_comment: Updates SecureDrop Workstation DispVMs at login
desktop_exec: /usr/bin/sdw-login
- user: {{ gui_user }}
- group: {{ gui_user }}
- mode: 664
- require:
- file: dom0-login-autostart-directory

so it has a hardcoded sleep to make sure the desktop is set up properly:

securedrop-workstation/files/sdw-login.py

Lines 17 to 21 in 95da570

if __name__ == "__main__":
# Wait for the dom0 GUI widgets to load
# If we don't wait, a "Houston, we have a problem..." message is displayed
# to the user.
time.sleep(5)

probably it should be a systemd unit that triggers on login, with the necessary Requires/After stanzas instead of a sleep
@rocodes rocodes self-assigned this Jun 17, 2024
@rocodes
Copy link
Contributor

rocodes commented Jun 17, 2024 •
edited
Loading

Helpful links here for our future selves

https://github.com/systemd/systemd/blob/main/docs/DESKTOP_ENVIRONMENTS.md
https://www.freedesktop.org/software/systemd/man/latest/systemd-xdg-autostart-generator.html

@rocodes rocodes linked a pull request Jun 17, 2024 that will close this issue
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rocodes rocodes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace sdw-login.py and .desktop file with systemd user unit freedomofpress/securedrop-workstation
2 participants
@legoktm @rocodes