Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused parts of strip-comments #126

Open
ojeytonwilliams opened this issue Jan 29, 2024 · 1 comment
Open

Remove unused parts of strip-comments #126

ojeytonwilliams opened this issue Jan 29, 2024 · 1 comment

Comments

@ojeytonwilliams
Copy link
Contributor

          Going through this made it obvious just how little of strip-comments we actually use. 

We should expand our tests a little (since we're implicitly relying on a bunch of tests in https://github.com/jonschlinkert/strip-comments that we don't run) and remove everything we don't need, but I'll do that in another PR.

Originally posted by @ojeytonwilliams in #120 (comment)

@a2937
Copy link
Member

a2937 commented Apr 25, 2024

Hi there. Should a test with this as the expected output actually pass? As things stand right now, I'm fairly certain it won't pass.

https://github.com/jonschlinkert/strip-comments/blob/master/test/expected/html/quoted.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants