Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update general-cs-quiz.ts #709

Merged
merged 5 commits into from
Oct 2, 2023
Merged

Update general-cs-quiz.ts #709

merged 5 commits into from
Oct 2, 2023

Conversation

dhruvjain896
Copy link
Contributor

Added a question based on trie data structure in general-cs-quiz

Summary of changes

Added a question based on trie data structure in general-cs-quiz

Checklist

  • I have read and followed the contribution guidelines.
  • I have read through the Code of Conduct and agree to abide by the rules.
  • This PR is for one of the available issues and is not a PR for an issue already assigned to someone else.
  • My PR title has a short descriptive name so the maintainers can get an idea of what the PR is about.
  • I have provided a summary of my changes.

closes #XXXXX

Added a question based on trie data structure in general-cs-quiz
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Please review the requested changes.
Once those changes have been implemented, then we can merge your PR into main. 👍

src/data/general-cs-quiz.ts Outdated Show resolved Hide resolved
src/data/general-cs-quiz.ts Outdated Show resolved Hide resolved
src/data/general-cs-quiz.ts Outdated Show resolved Hide resolved
dhruvjain896 and others added 3 commits October 2, 2023 19:32
Changes Grammar in Question

Co-authored-by: Jessica Wilkins  <[email protected]>
Changed grammar in Explanation

Co-authored-by: Jessica Wilkins  <[email protected]>
Changed link for the answer

Co-authored-by: Jessica Wilkins  <[email protected]>
@dhruvjain896
Copy link
Contributor Author

@jdwilkin4 I have applied all the changes suggested by you.

@jdwilkin4
Copy link
Contributor

@dhruvjain896

The changes look good.
Once you resolve the merge conflicts then this PR can be approved and merged

@dhruvjain896
Copy link
Contributor Author

@jdwilkin4 Resolved merge conflicts

Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on another contribution to our repository. 🎉
We look forward to future contributions. 👍

@jdwilkin4 jdwilkin4 merged commit c365c5e into freeCodeCamp:main Oct 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants