Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update general-cs-quiz.ts #704

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Update general-cs-quiz.ts #704

merged 2 commits into from
Oct 3, 2023

Conversation

Amit0042
Copy link
Contributor

@Amit0042 Amit0042 commented Oct 2, 2023 •
edited
Loading

Added a new quiz question-
"What does NFC stands for?"
Please review it.

Summary of changes

Added a new quiz question-
"What does NFC stands for?"

Checklist

  • I have read and followed the contribution guidelines.
  • I have read through the Code of Conduct and agree to abide by the rules.
  • This PR is for one of the available issues and is not a PR for an issue already assigned to someone else.
  • My PR title has a short descriptive name so the maintainers can get an idea of what the PR is about.
  • I have provided a summary of my changes.

closes #XXXXX

@Amit0042
Update general-cs-quiz.ts
d9373c3 
Added a new quiz question-
"What does NFC stands for?"
@Amit0042
Copy link
Contributor Author

Amit0042 commented Oct 2, 2023

Please review the question

@Amit0042 Amit0042 closed this Oct 2, 2023
@Amit0042 Amit0042 reopened this Oct 2, 2023
jdwilkin4
jdwilkin4 requested changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Please review the requested changes.
Once those changes have been implemented, then we can merge your PR into main. 👍

src/data/general-cs-quiz.ts Outdated Show resolved Hide resolved
src/data/general-cs-quiz.ts Outdated Show resolved Hide resolved
@Amit0042
Update general-cs-quiz.ts
a30cfa0 
I have changed the question accordingly as per your suggestion.
@Amit0042
Copy link
Contributor Author

Amit0042 commented Oct 3, 2023 •
edited
Loading

I have changed the question accordingly as per your suggestion. Please review it.

jdwilkin4
jdwilkin4 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first contribution to our repository. 🎉
We look forward to future contributions. 👍

@jdwilkin4 jdwilkin4 merged commit e2bc2a4 into freeCodeCamp:main Oct 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdwilkin4 jdwilkin4 jdwilkin4 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amit0042 @jdwilkin4