Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a question regarding rel attribute in accessibility quiz.ts #703

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Add a question regarding rel attribute in accessibility quiz.ts #703

merged 3 commits into from
Oct 2, 2023

Conversation

sanjaypinna
Copy link
Contributor

@sanjaypinna sanjaypinna commented Oct 2, 2023

Summary of changes

This PR replace a duplicate question (which already exist in line number 346 -356) with a new one regarding rel attribute in accessibility quiz.

Checklist

  • I have read and followed the contribution guidelines.
  • I have read through the Code of Conduct and agree to abide by the rules.
  • This PR is for one of the available issues and is not a PR for an issue already assigned to someone else.
  • My PR title has a short descriptive name so the maintainers can get an idea of what the PR is about.
  • I have provided a summary of my changes.

Relates to #374

Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Please review the requested changes.
Once those changes have been implemented, then we can merge your PR into main. 👍

src/data/accessibility-quiz.ts Outdated Show resolved Hide resolved
src/data/accessibility-quiz.ts Outdated Show resolved Hide resolved
@sanjaypinna
Copy link
Contributor Author

@jdwilkin4 thanks you for pointing out the mistake I made the changes as requested, you can merge it

Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first contribution to our repository. 🎉
We look forward to future contributions. 👍

@jdwilkin4 jdwilkin4 merged commit cdd87af into freeCodeCamp:main Oct 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants