Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate JS quiz question #680

Merged
merged 1 commit into from
Sep 18, 2023
Merged

fix: remove duplicate JS quiz question #680

merged 1 commit into from
Sep 18, 2023

Conversation

Gautam-Hegde
Copy link
Contributor

@Gautam-Hegde Gautam-Hegde commented Sep 18, 2023

Checklist:

Summary of changes

Removed duplicate quiz question bug in the JavaScript module.

Checklist

  • I have read and followed the contribution guidelines.
  • I have read through the Code of Conduct and agree to abide by the rules.
  • This PR is for one of the available issues and is not a PR for an issue already assigned to someone else.
  • My PR title has a short descriptive name so the maintainers can get an idea of what the PR is about.
  • I have provided a summary of my changes.

closes #679

@jdwilkin4
Copy link
Contributor

Hi there!

It looks like you created a PR for an issue marked with the Available for assignment label.

We will only accept PR's from those who are assigned to that particular issue.

It looks like this issue hasn't been assigned yet, but it is important that we follow the process so we don't have multiple people submitting PR's for the same issue.

Before any reviews can take place, please read through our contributing docs to learn more about how the process works.
https://github.com/freeCodeCamp/Developer_Quiz_Site/blob/main/CONTRIBUTING.md#issues-available-for-contribution

Thank you for your understanding 👍

@Gautam-Hegde
Copy link
Contributor Author

Hi there!

It looks like you created a PR for an issue marked with the Available for assignment label.

We will only accept PR's from those who are assigned to that particular issue.

It looks like this issue hasn't been assigned yet, but it is important that we follow the process so we don't have multiple people submitting PR's for the same issue.

Before any reviews can take place, please read through our contributing docs to learn more about how the process works. https://github.com/freeCodeCamp/Developer_Quiz_Site/blob/main/CONTRIBUTING.md#issues-available-for-contribution

Thank you for your understanding 👍

Yeah! I made a PR because the issue wasn't assigned to anyone 😅

@jdwilkin4 jdwilkin4 changed the title chore : Duplicate bug fix fix: remove duplicate JS quiz question Sep 18, 2023
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on another contribution to our repository. 🎉
We look forward to future contributions. 👍

@jdwilkin4 jdwilkin4 merged commit bb4d908 into freeCodeCamp:main Sep 18, 2023
2 checks passed
@jdwilkin4
Copy link
Contributor

Yeah! I made a PR because the issue wasn't assigned to anyone

In the future, please make sure to ask to be assigned to issues marked with Available for assignment label.
We want to eliminate what happened last year during hacktoberfest where multiple people were trying to work on the same issue and arguing over it.

This makes for a cleaner process. 👍

@Gautam-Hegde Gautam-Hegde deleted the Patch-Duplicate_Fix branch September 18, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate JavaScript quiz question
2 participants