Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-square 2D grids #1

Open
w-m opened this issue Feb 23, 2024 · 1 comment
Open

Support non-square 2D grids #1

w-m opened this issue Feb 23, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@w-m
Copy link
Collaborator

w-m commented Feb 23, 2024

For simplification, the current implementation only supports square grids. For broader use, it would be useful to extend support to rectangular grids.

@w-m w-m added the enhancement New feature or request label Feb 23, 2024
w-m added a commit that referenced this issue May 8, 2024
@w-m
Copy link
Collaborator Author

w-m commented May 8, 2024

It doesn't crash when sorting non-square grids, but the code in the grid reorganization has only one variable for block size and number of blocks (independent of x/y dim), e.g. https://github.com/fraunhoferhhi/PLAS/blob/main/plas.py#L238-L239 - thus it doesn't properly sort the non-square overhanging part.

Doesn't really make sense fixing this state of the code for non-square grids, as it contains the overly complicated but dead/unused pixel unshuffling.

-> do non-square support after rewrite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant