-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slack app bot invalid_auth even though it's valid #114
Comments
It looks like the Slacker python package is no longer supported, and their auth header doesn't play well with Slack at the moment. I'm new to this project, so maybe this is a recent slack change? I got it to work with a little modification to the Slacker.init.py file of line 69 (of the latest version) to change from Ultimately, the longer term solution may be to move away from using the unsupported Slacker package and use Slack's own SDK. |
Hi @sfoley I agree - I recall looking into moving away from Slacker a few months ago but I haven't been able to put aside the time to knock this out just yet. A quick hack (which could have some legs since the Slacker project is dead) would be to patch that method but that's never ideal. TBD when I'll get around to knocking this out but with Slacker long since dead, it's about time I get rid of that dependency. |
following because i'm having the same issue. |
Following, currently using the web hook method but I really want the full bot! |
Update - I've ripped out Slacker and am in the testing phase of Pytyon2 support. Once that testing (and corresponding bug fixes) is complete, I'll add Python3 support, go through that testing cycle and then we should be good to go. No ETA yet but these changes are underway. |
Awesome! I’m down to pull down a branch and test. |
Hi @eecue https://github.com/fraschetti/Octoslack/tree/SlackerRemoval Looking good for Python2, haven't started work on Python3. |
Heya @fraschetti ... any update here? I'm running Python 3 so didn't get a chance to test your PR. |
Same boat. I'm happy to take a look at whatever python3 work you are able to put together. |
FYI - I've started work on Python3 support for the official Slack Python library. Stay tuned. |
Update - I've completed both Python2 & Python3 development and testing. Changes has been submitted to that development branch: I'll let these bake for a couple of days but pending any bug reports, a new release with these changes should be coming soon. |
Edit: it works! I had to totally delete my old settings and reinstall |
Thanks for the feedback @eecue Thanks in advance. |
So I first tried to just check out your branch and copy the files into the python folder over the existing ones. That didn’t work and octoslack didn’t even appear. Then I just downloaded the whole zip of the branch and upload it via the web interface. That started working again and my old settings were in there but I got an error message. I posted it earlier and then edited my message, sorry. I can grab it from the logs once I’m home later. I then removed and cleaned the plug-in, added it again using the zip upload method, added back my creds and all was good. |
Thanks @eecue - my local upgrade tests look good but I'd still be interested to see anything you can provide. Thanks! |
@fraschetti I can confirm what eecue was saying. I pulled the plugin and installed via ZIP. I too had to trash creds, but all looks good. |
I'd of course like to track down any issues on my side but if there's something I can't fix, I'd ideally likely to call this out in the release notes. Thanks again. |
@dstrivelli so I had already created both the bot token and the web hook info and added both to the config, but was using the web hook as the bot didn't work before your awesome update. so I did not have to regenerate anything, just deleted and paste it back in ... btw here are the errors I saw before I deleted:
|
@fraschetti I did not need to recreate the Slack credentials, I just needed to delete OctoSlack plugin from OctoPrint entirely, and all of its data, then install from the ZIP file. I had the same error that @eecue posted above when I had just installed the updated version over the top of the existing install.
But when I specified an authorized user in the plugin settings, everything was good to go. Doesn't seem to work in private channels, but that may be by design or at least a known limitation, I'm not sure. Otherwise, works great. |
I found a few extra places where I need to make changes to adapt to the new Slack client response objects (no longer a native dictionary and they don't fully support all dictionary functionality). I just pushed 2.2.0 - https://github.com/fraschetti/Octoslack/releases/tag/2.2.0 Thanks for your help! |
I can not get app bot to work. In the logs it shows this...
octoprint.plugins.Octoslack - ERROR - Error in Slack Web API event loop, Error: invalid_auth
However if I use the slack documentation demo curl call using exact same token it works...
So I know the token works and that the bot is in the channel. Perhaps something else is going on?
The text was updated successfully, but these errors were encountered: