Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML files cannot be generated anymore #1487

Open
tobehn opened this issue Oct 6, 2024 · 2 comments
Open

YAML files cannot be generated anymore #1487

tobehn opened this issue Oct 6, 2024 · 2 comments
Labels

Comments

@tobehn
Copy link

tobehn commented Oct 6, 2024

Since this commit #1403 building the erpnext-one.yaml file is not possible anymore.

I always get the ERROR:
invalid interpolation format for x-backend-defaults.image: "${ERPNEXT_VERSION:?No ERPNext version or tag set". You may need to escape any $ with another $.

Even though i definitely have set ERPNEXT_VERSION the build process does not recognize it anymore. With the former image declaration everything works fine.
image: frappe/erpnext:${ERPNEXT_VERSION:?No ERPNext version set}

with the new image declaration the generating the YAML fails and the file stay empty.

  image: ${CUSTOM_IMAGE:-frappe/erpnext}:${CUSTOM_TAG:-${ERPNEXT_VERSION:?No ERPNext version or tag set}}
  pull_policy: ${PULL_POLICY:-always}

I have also tried seting CUSTOM_IMAGE and CUSTOM_TAG to frappe/erpnext and the corresponding Version i wanted to use.

How do i need to adapt to this change?

@tobehn tobehn added the bug label Oct 6, 2024
@tobehn tobehn changed the title YAML fils cannot be generated anymore YAML files cannot be generated anymore Oct 6, 2024
@revant
Copy link
Collaborator

revant commented Oct 10, 2024

Try

--env-file /path/to/.env

@tobehn
Copy link
Author

tobehn commented Oct 10, 2024

Thank you very much for answering:
Well, thats exactly what i do.

docker compose --project-name erpnext-one \
  --env-file ~/gitops/erpnext-one.env \
  -f compose.yaml \
  -f overrides/compose.redis.yaml \
  -f overrides/compose.multi-bench.yaml \
  -f overrides/compose.multi-bench-ssl.yaml config > ~/gitops/erpnext-one.yaml

and this raises the error, even though i have ERPNEXT_VERSION defined in the *.env file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants