From fa657d347ebc38041ff2530d43bc7b7dca30cef0 Mon Sep 17 00:00:00 2001
From: Francisco Giordano <frangio.1@gmail.com>
Date: Mon, 7 Jun 2021 16:03:45 -0300
Subject: [PATCH] fix storage location for constructor arguments

---
 CHANGELOG.md          |   4 ++++
 contracts/Test.sol    |   4 ++++
 src/core.test.ts.md   |   4 ++++
 src/core.test.ts.snap | Bin 623 -> 656 bytes
 src/core.ts           |   2 +-
 5 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index e13df64..31ee1d1 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.1.4
+
+- Fix storage location for constructor arguments.
+
 ## 0.1.3
 
 - Fix functions with enum and contract arguments.
diff --git a/contracts/Test.sol b/contracts/Test.sol
index abb76f7..77698cf 100644
--- a/contracts/Test.sol
+++ b/contracts/Test.sol
@@ -84,3 +84,7 @@ contract Types {
     function _testContractType(Types t) internal {}
     function _testMappingType(mapping (uint => uint) storage m) internal {}
 }
+
+contract ConstructorStorageLocation {
+    constructor(string memory name) {}
+}
diff --git a/src/core.test.ts.md b/src/core.test.ts.md
index 55f1272..a6e1d35 100644
--- a/src/core.test.ts.md
+++ b/src/core.test.ts.md
@@ -141,4 +141,8 @@ Generated by [AVA](https://avajs.dev).
             return super._testContractType(t);␊
         }␊
     }␊
+    ␊
+    contract XConstructorStorageLocation is ConstructorStorageLocation {␊
+        constructor(string memory name) ConstructorStorageLocation(name) {}␊
+    }␊
     `
diff --git a/src/core.test.ts.snap b/src/core.test.ts.snap
index f164b995a997b0a8f1e46d1a00c9f579c1259d95..950f608a606c743981e44b2ebe104e1e8156873e 100644
GIT binary patch
literal 656
zcmV;B0&o36RzV<BZeeh9Xm4~Nb}|YA02@NQxjw4`-tSA`zS|<u*B^@r00000000B+
zR^4h7K@{F7B5bev28Ud2z;0?%dtp(~G(sTM!dB>=Og57^keyv-W^Iy^ck&%dUqJE3
z3lVR;6<<JSW`8Cz*=^E7so>nq$)0n*@0)WDGXcx8D%M5y)7RR^50~G+ZGZXvWA>|J
zsr7ryvhG_CwOx5&ZQuL3Rj-40e0aLkB|fGc?{xZ@3Nj#=J%u+%-A=20<h2iNJ7Q=U
zAmHJM^of|j^Jly6zPo#1+a!oWCZOuNbw8wnAz$$N3Fg9;!BrWMeTCCkVF-kS+Rkl|
zOS-sVu`fdA)Zlz(>#u{D`htWM#&3nhk>S#b#{x5oMi9je1H&R_l!Fr!DjHArYbl^w
zi4S-jVdffy10ArM!V`?pVKEEWeh6?7vPn5t26Y9UJaaLf)a!cdvT3BN**sZeG{moC
z5ycDC?+HG;KJ{O)nU2|f+g~E4+OD<@+AhOy*mjLjR+;~k^^Z?hm-IFnDH(p9e#<o1
z<j)B~J)Q_LiaG=2V>RuGQ6O%0?u#B*nQAM}GvTd}`ck20%k4F*k+I)k{0+p))*K@y
zUy{d4TxKq7OG#i{%YvM7VfV6#Imu;Hl!uqdYZ!Tr5_ywMUc;Fz_aSjL4OFuPYMMbc
zo#~2}z9XZ)u32i`rIKk$ja*z=!N!kZsdifDVi|8oax<4))|fjbc`ui|x29xcPL1go
z9b|3<6Bft6oztC6BCIdD#Mt2OZqqnWNsi8R)la}{YRYqQ>2uafWf~d~YcedPih|CX
qW2SFgH}sL_Pj2uc?{bwE{xtwafviL^fRhC1%jOU4jE(yr3;+Odg*{sU

literal 623
zcmV-#0+9VdRzV<BZeeh9Xm4~Nb}|YA0Jp*eD`x<cJu>w5)eECNCm)Ll00000000B+
zmCbI`KoG|r5JGZKeS=X>jzpc}lpd%+f;32xqEg94>J1!c6IP0Mt=%=)sq#*|1L6fh
zTsR=ag*#8c?mGSmiQS}?sv@zM9eZcy|J#|74TfPfjE~JP-&>zQeERug_uJQB^WP0a
zExKbEca8hnZrn3=@4VS*x4}I<KHnQ)9}$lB`XfXH9%IBF!>f})zuP-;d&j03GH()i
z!08l^ut?zPlYRTp-aj%;9E6k!Xxet$r$jK%7rcFjxUi*jQ#xdC;rs=qfH|n`!UVbG
z5f?1-1!YzXF6O3wJC2AiFeMPb7BY`?mxm}8h!JlJVZ;zHBqByQSP>?|d34xXBvdOs
z10IEl*+qsU?XX_L6%3O}wF=kg5TJmvq+Tmab%~t3bG4l0wcSnCbf(MITv=mpf?h@<
zjFzO|Vf6m$(toARIOgTHKlhkwyV|yByL7*1+jWMz%KV?Ke|)kAc(~0-N%yPtTZY+1
zd<n!G@)V>X>W@7iscBD*3b^&L&xTw@s;xS%aPLy$OG2%d+Z$FRQ@_Ue7b(`Z=G0^I
zPx4T~W#%f|LImPg=48c{-OD^m$aPbcyVu}31)fubmt=U3m8|w5J?a#xIyI?gS*ngT
zThr3FcskNGTUfWLWE#oI;pz$&KY*3mY0l*`-VAalN3LtktwKJ?kq<URF3eeB`c)Sx
zjbN%``8RXBvm`|NBbORme7k!j3RIA#BW?8vXhWtv7S;aFx(m!g2E>L6OQE84_dlYG
J{q~Ow002;VEDHbt

diff --git a/src/core.ts b/src/core.ts
index ea422dc..2a346ee 100644
--- a/src/core.ts
+++ b/src/core.ts
@@ -139,7 +139,7 @@ function makeConstructor(contract: ContractDefinition, contractMap: ContractMap)
     const args = [];
     for (const a of getConstructor(c)!.parameters.parameters) {
       const name = missingArguments.has(a.name) ? `${c.name}_${a.name}` : a.name;
-      const type = getType(a, 'calldata');
+      const type = getType(a, 'memory');
       missingArguments.set(name, type);
       args.push(name);
     }