Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Windows installer not available for 1.6.2 #283

Open
modem7 opened this issue Nov 18, 2023 · 3 comments
Open

[BUG] Windows installer not available for 1.6.2 #283

modem7 opened this issue Nov 18, 2023 · 3 comments
Assignees
Labels
Bug Bug that makes GitQlient unstable. It doesn't crash

Comments

@modem7
Copy link

modem7 commented Nov 18, 2023

Describe the bug
Windows installer not available for 1.6.2.

Last available is 1.6.0. Possible workflow issue?

@modem7 modem7 added the Bug Bug that makes GitQlient unstable. It doesn't crash label Nov 18, 2023
@francescmm
Copy link
Owner

Hi @modem7, I'm aware of the Windows "issue". The problem is that I cannot ship the installer I was using before for license issues, so I need to check if I can get a new one.

Installing all Qt dependencies manually is quite tedious on Windows so I'd prefer to avoid that pain to the user.

Let's see what I can do, and sorry for the trouble! :)

@jo-chemla
Copy link

Releasing GitQlient as a winget-pkgs package would enable you to specify Qt as a dependency - eg the way this is done here for dependencies of UnigetUI.

# installer.yaml

# Created with WinGet Releaser v2 using Komac v1.11.0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.5.0.schema.json
PackageIdentifier: MartiCliment.UniGetUI
PackageVersion: 3.1.3
# ...
Dependencies:
  PackageDependencies:
  - PackageIdentifier: Microsoft.VCRedist.2015+.x64
    MinimumVersion: 14.40.33816.0
# ...
Installers:
- Architecture: x64
  InstallerUrl: https://github.com/marticliment/UniGetUI/releases/download/3.1.3/UniGetUI.Installer.exe
  InstallerSha256: 58AE121CD325B7F5AEF6ED07E21D72A89BA0E7FF6ADDB2FB339A69DCFEFAD6B4
  # ...

If this is helpful, I can publish the initial manifest release for 1.6.0 using Komac, then you could define a github-action workflow based on winget-releaser-v2 - again this example from UnigetUI is useful.

name: Publish stable releases to WinGet
on:
  release:
    types: [released]
  workflow_dispatch:

jobs:
  publish:
    runs-on: ubuntu-latest
    steps:
      - uses: vedantmgoyal2009/winget-releaser@v2
        with:
          identifier: francescmm.GitQlient # use your identifier
          version: ${{ github.event.release.tag_name }}
          token: ${{ secrets.WINGET_TOKEN }} # and token
          installers-regex: '\.exe$' # Only .exe files

@francescmm
Copy link
Owner

Thanks for the input @jo-chemla! I'll make some tries during this week and upcoming week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug that makes GitQlient unstable. It doesn't crash
Projects
None yet
Development

No branches or pull requests

3 participants