Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After a transaction, ctx.message.transactionId is not set on XMTP #440

Closed
pradel opened this issue Jul 2, 2024 · 13 comments
Closed

After a transaction, ctx.message.transactionId is not set on XMTP #440

pradel opened this issue Jul 2, 2024 · 13 comments
Assignees

Comments

@pradel
Copy link

pradel commented Jul 2, 2024

Following up #433, the error from the debugger was fixed and now the success route is called properly but the transaction ID is missing from the payload. I logged the full ctx object and it's not present there, the example shows ctx.message.transactionId but this value is not set for XMTP.

@michalkvasnicak michalkvasnicak self-assigned this Jul 3, 2024
@michalkvasnicak
Copy link
Collaborator

@pradel thank you for the report, I found the culprit and implemented a fix but it's not working at the moment because of issue in upstream dependency, xmtp/xmtp-node-js-tools#259

@pradel
Copy link
Author

pradel commented Jul 3, 2024

@michalkvasnicak thanks for the fast response, will try to see if I can manually upgrade the @xmtp/proto version for my project for the time being :)

@michalkvasnicak
Copy link
Collaborator

@pradel that could help but you still need to wait for fix in debugger because we aren't sending the transactionId there cause it used outdated @xmtp/proto as well. Sorry for inconvenience.

michalkvasnicak added a commit that referenced this issue Jul 3, 2024
@pradel
Copy link
Author

pradel commented Jul 3, 2024

Just tested with the latest version and I am still not able to access the transactionId, it is now set to an empty string. This is the payload I am seeing

message: {
    frameUrl: 'http://localhost:3000/',
    buttonIndex: 2,
    timestamp: Long { low: 2022032215, high: 400, unsigned: true },
    opaqueConversationIdentifier: 'xxx',
    unixTimestamp: 2022032215,
    inputText: '',
    state: '{xxx}',
    address: '',
    transactionId: '',
    verifiedWalletAddress: '0x...'
  },

@pradel
Copy link
Author

pradel commented Jul 3, 2024

@michalkvasnicak I am using version 0.3.3 of the debugger

@michalkvasnicak
Copy link
Collaborator

That's weird, I tried it with rainbowkit and it worked fine for me.

@pradel
Copy link
Author

pradel commented Jul 3, 2024

@michalkvasnicak I tried with the rabby extension on desktop and rainbow mobile (via wallet connect) and with both I am having the empty string

@michalkvasnicak
Copy link
Collaborator

michalkvasnicak commented Jul 3, 2024

@pradel I tried Rabby extension and it works could you provide minimum reproducible repository?

@pradel
Copy link
Author

pradel commented Jul 3, 2024

@michalkvasnicak can try, do you have a good starter I can use to make things easier on my side as I can't share the full project?

@michalkvasnicak
Copy link
Collaborator

We have this starter for transactions https://github.com/framesjs/frames.js/tree/main/templates/next-starter-with-examples/app/examples/transactions

To quickly create a new project with the template you can follow this guide: https://framesjs.org/#bootstrap-the-project-from-template-using-the-cli-tool

But I changed 2 files locally just to send transaction to myself: https://gist.github.com/michalkvasnicak/f78a5732dc666690838aae8937866114

@pradel
Copy link
Author

pradel commented Jul 3, 2024

Thanks!

@pradel
Copy link
Author

pradel commented Jul 3, 2024

@michalkvasnicak just tried with your example and I am also getting an empty string transactionId, I am doing the tx on polygon but I don't think it's related?

@michalkvasnicak
Copy link
Collaborator

@pradel sorry I completely missed this comment. I think @stephancill is the best person for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants