-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After a transaction, ctx.message.transactionId is not set on XMTP #440
Comments
@pradel thank you for the report, I found the culprit and implemented a fix but it's not working at the moment because of issue in upstream dependency, xmtp/xmtp-node-js-tools#259 |
@michalkvasnicak thanks for the fast response, will try to see if I can manually upgrade the |
@pradel that could help but you still need to wait for fix in debugger because we aren't sending the |
Just tested with the latest version and I am still not able to access the transactionId, it is now set to an empty string. This is the payload I am seeing
|
@michalkvasnicak I am using version |
That's weird, I tried it with rainbowkit and it worked fine for me. |
@michalkvasnicak I tried with the rabby extension on desktop and rainbow mobile (via wallet connect) and with both I am having the empty string |
@pradel I tried Rabby extension and it works could you provide minimum reproducible repository? |
@michalkvasnicak can try, do you have a good starter I can use to make things easier on my side as I can't share the full project? |
We have this starter for transactions https://github.com/framesjs/frames.js/tree/main/templates/next-starter-with-examples/app/examples/transactions To quickly create a new project with the template you can follow this guide: https://framesjs.org/#bootstrap-the-project-from-template-using-the-cli-tool But I changed 2 files locally just to send transaction to myself: https://gist.github.com/michalkvasnicak/f78a5732dc666690838aae8937866114 |
Thanks! |
@michalkvasnicak just tried with your example and I am also getting an empty string |
@pradel sorry I completely missed this comment. I think @stephancill is the best person for this. |
Following up #433, the error from the debugger was fixed and now the success route is called properly but the transaction ID is missing from the payload. I logged the full
ctx
object and it's not present there, the example showsctx.message.transactionId
but this value is not set for XMTP.The text was updated successfully, but these errors were encountered: