Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stretched/cropped video if Android device's screen aspect ratio doesn't match DJI Camera's 4:3 / 16:9 #5

Closed
failsafe-fpv opened this issue May 14, 2021 · 4 comments · Fixed by #40
Closed

Stretched/cropped video if Android device's screen aspect ratio doesn't match DJI Camera's 4:3 / 16:9 #5

failsafe-fpv opened this issue May 14, 2021 · 4 comments · Fixed by #40
Assignees
@fichek
Labels
enhancement New feature or request
Milestone
BETA version

Comments

@failsafe-fpv
Copy link

Amazing work btw, latency is so low and app functions really well!

I usually fly with 4:3 mode set in the goggles (to get the widest FOV) but on digiview it seems to stretch the incoming 4:3 stream into 16:9, filling my phone screen but distorting the image.

Thanks,

FailsafeFPV
@failsafe-fpv failsafe-fpv changed the title 4:3 mode on dji goggles results in a stretched 16:9 video on digiview 4:3 mode on dji goggles results in a stretched 16:9 video feed on digiview May 14, 2021
@failsafe-fpv failsafe-fpv changed the title 4:3 mode on dji goggles results in a stretched 16:9 video feed on digiview 4:3 mode on dji goggles results in a stretched(or cropped) 16:9 video feed on digiview May 14, 2021
@xviews
Copy link

xviews commented May 14, 2021

An option for stretch on or off would be good

@jlucidar
Copy link
Member

Would be great to have this in the beta version !

@jlucidar jlucidar added the enhancement New feature or request label May 14, 2021
@jlucidar jlucidar added this to the BETA version milestone May 14, 2021
@fichek fichek mentioned this issue May 16, 2021
Closed
@fichek fichek changed the title 4:3 mode on dji goggles results in a stretched(or cropped) 16:9 video feed on digiview Stretched/cropped video if Android device' screen aspect ratio doesn't match DJI Camera's 4:3 / 16:9 May 16, 2021
@fichek
Copy link
Member

fichek commented May 16, 2021

Changed title to be more generic as the same problem exists with 16:9 video on 4:3 screens (see #34). Got a fix for this, will open a PR soon.

@fichek fichek changed the title Stretched/cropped video if Android device' screen aspect ratio doesn't match DJI Camera's 4:3 / 16:9 Stretched/cropped video if Android device's screen aspect ratio doesn't match DJI Camera's 4:3 / 16:9 May 17, 2021
@fichek fichek mentioned this issue May 17, 2021
Merged
@fichek fichek linked a pull request May 17, 2021 that will close this issue
Video aspect-fit to native ratio, toggle with double tap/pinch #40
Merged
@fichek
Copy link
Member

fichek commented May 17, 2021

PR #40 was merged, this will be in the beta release, including zoom in/out as suggested by @xviews 🥳

@fichek fichek closed this as completed May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fichek fichek

Labels
enhancement New feature or request
Projects
None yet
Milestone
BETA version
Development

Successfully merging a pull request may close this issue.

Video aspect-fit to native ratio, toggle with double tap/pinch fpvout/DigiView-Android
4 participants
@fichek @jlucidar @failsafe-fpv @xviews