Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate setConfiguration and setModelConfig in ModelController.js #3

Open
fe-wickham opened this issue Aug 25, 2020 · 0 comments
Open

Consolidate setConfiguration and setModelConfig in ModelController.js #3

fe-wickham opened this issue Aug 25, 2020 · 0 comments

Comments

@fe-wickham
Copy link
Member

They are really similar but they aren't the same. Notably setConfiguration just updates the fields while intentionally not setting data and setModelConfig is replacing the whole object and ensures views and containers are initialized. While I am sure they can eventually be consolidated, its slightly non-trivial to ensure there aren't adverse effects with what the web app is expecting to have happen.

Originally posted by @fe-wickham in #1 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fe-wickham