Change name of custom_functions.h

[audiologic-vannoy]

The file is really just fixed point to string and vice versa conversion funcitons. There is probably a name that better describes what the file is actually doing.

Changing the file name will necessitate changing the device driver autogen to reflect the new file name.

[tvannoy]

There's also the question of whether we want these functions to be defined in the header file like they are now, or if we want to put them in a c file instead.

[tvannoy]

custom_functions.h lives in the component_library now. The #include in the device driver codegen will need to be changed to reflect the new name. The include path in the autogenerated makefile shouldn't need to change.

[fe-wickham]

Is there a reason we have the strcat2 function instead of just using strcat?

[tvannoy]

Unfortunately, yes. Kernel source code can't use the std library functions since they are written for user space. https://kernelnewbies.org/FAQ/LibraryFunctionsInKernel

However, it's entirely possible that there is already a kernel version of strcat available for use in the kernel source tree. If that's the case, it would be better to use that version instead of our (probably buggy) version.

[fe-wickham]

Given it is in string.h though shouldn't we be able to use it that way?

[tvannoy]

Yes, you are correct. Whoever implemented the driver did not know that there is a kernel version of string.h that implements many of the functions in the user space string.h (located at /usr/include/string.h)

Let's use include/linux/string.h

[tvannoy]

There are probably other functions, such as strcpy, we could replace that I believe we are duplicating in our drivers.