Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically refreshes the current tab after switching proxies #109

Open
Hill-98 opened this issue Jan 1, 2024 · 7 comments
Open

Automatically refreshes the current tab after switching proxies #109

Hill-98 opened this issue Jan 1, 2024 · 7 comments
Labels
feature request New feature or request

Comments

@Hill-98
Copy link

Hill-98 commented Jan 1, 2024

Adding an option to control whether or not the current tab is automatically refreshed after switching proxies is a very useful feature.

if some website is inaccessible and I switch proxies to access it, an automatic refresh would free my hands.

@erosman
Copy link
Collaborator

erosman commented Jan 1, 2024

There are practical considerations:

  • FoxyProxy doesn't have a direct connection to the tabs
  • FoxyProxy runs in the background before a page is requested
  • FoxyProxy isn't aware if the web site is accessible or not, as its process has ended before a page is requested

@Hill-98
Copy link
Author

Hill-98 commented Jan 1, 2024

Regarding the third point, I may not have made it clear that there is no need to let FoxyProxy know if the site is accessible or not, just refresh the tab when switching proxies.

FoxyProxy is not directly connected to the tab, so is it possible to notify the browser of a refresh operation?

@erosman
Copy link
Collaborator

erosman commented Jan 1, 2024

It is not certain that everyone would want to have their current tab refreshed when a proxy is changed.
The proxy may or may not be related to that tab (e.g. through patterns).
Imagine being in the middle of a game, or filling a firm, or watching a clip and suddenly a tab which was not proxied gets refreshed, resulting in loss of data.
How would anyone know if the user wants the tab refreshed or not?

What about other tabs? Should all tabs be refreshed? Why not?

Finally, it involves a lot of additional processing to avoid an F5 to refresh the tab.

@Hill-98
Copy link
Author

Hill-98 commented Jan 1, 2024

So I want to make it an option and the default behavior remains the same as it is now.

@erosman
Copy link
Collaborator

erosman commented Jan 2, 2024

OK, let's see if there is a popular demand for implementing the feature.

@erosman erosman added the feature request New feature or request label Jan 2, 2024
@songliansheng
Copy link

From my understanding ,proxy by patterns should meet your requirements , the first time a site can't be opened ,you can include it in a proxy , then you don't have to worry about it anymore

If you switch proxy manually every time ,isn't this troublesome?

@Hill-98
Copy link
Author

Hill-98 commented Feb 29, 2024

@songliansheng Because I have many proxies, sometimes I may need to temporarily switch to another one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants