-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message.sequence: wording mistake? #926
Comments
Internal tracking ticket: FG-4352 |
I proposed a fix in #927 |
Hi, I believe this is not really a wording mistake per se... it's trying to say that since the field is required, if the publisher does not provide a sequence number then the recorder will have to come up with one. However, I agree that the wording is unclear. We will discuss internally. |
Thanks for clarifying that out, this is important to me.
I'll leave this open for a while, since that would still contradict with the My suggestions would be:
|
@omegacoleman I have raised a PR here to propose some new wording if you're interested: #938 |
Description
Hi, I'm trying to implement a mcap-compatible bag facility for a self-driving system. While I appreciate your hard work, I suspect a wording mistake in
spec/index.md
:It says the sequence is optional, but "If not assigned by publisher, must be recorded by the recorder.", wouldn't that contradict with 'optional'?
It seems like a wording mistake of "If assigned by publisher, must be recorded by the recorder."
The text was updated successfully, but these errors were encountered: