Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set a username on custom heads #30

Closed
foxfirecodes opened this issue Sep 24, 2020 · 1 comment
Closed

Don't set a username on custom heads #30

foxfirecodes opened this issue Sep 24, 2020 · 1 comment

Comments

@foxfirecodes
Copy link
Owner

(see meiskam/PlayerHeads#18 for more context)

tl;dr setting a custom username on decoheads is misleading, since there's no real username associated with said head. the solution is to just provide null for the username.
@foxfirecodes foxfirecodes mentioned this issue Sep 24, 2020
Open
@crashdemons crashdemons mentioned this issue Sep 24, 2020
Closed
foxfirecodes added a commit that referenced this issue Sep 24, 2020
@foxfirecodes
Dont set a username on custom heads (#30)
0a699ae
@foxfirecodes
Copy link
Owner Author

fixed in 0a699ae / dev build 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@foxfirecodes