Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we modify cache-control header on cached response #1

Open
four43 opened this issue Jan 5, 2016 · 0 comments
Open

Ensure we modify cache-control header on cached response #1

four43 opened this issue Jan 5, 2016 · 0 comments

Comments

@four43
Copy link
Owner

four43 commented Jan 5, 2016

We need to update the cache-control header when serve out a cached response to make sure we subtract the elapsed time, for example:

First response at 02:00:00
Date: 02:00:00
Expires: 02:01:00
Cache-Control: max-age=60

Second response at 02:00:30 (cached)
Expires: 02:01:00
Cache-Control: max-age=60

^^ max-age should now be 30, not 60

Good thinking @eschwartz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant