Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing docs for attributes #2026

Closed
Draggu opened this issue Apr 15, 2024 · 7 comments · Fixed by #2255
Closed

Add missing docs for attributes #2026

Draggu opened this issue Apr 15, 2024 · 7 comments · Fixed by #2255
Assignees
Labels
documentation Improvements or additions to documentation snforge

Comments

@Draggu
Copy link
Contributor

Draggu commented Apr 15, 2024

Which components does the task require to be changed? (think hard pls)

snforge

Description

  • available_gas
  • etc...
@github-actions github-actions bot added the new label Apr 15, 2024
@Draggu Draggu added documentation Improvements or additions to documentation snforge and removed new labels Apr 15, 2024
@Jemiiah
Copy link

Jemiiah commented Apr 16, 2024

@Arcticae please can i be assigned this work?

@Mystic-Nayy
Copy link

@Draggu Can you please assign this to me?

@Arcticae
Copy link
Contributor

@Jemiiah if you have any questions about execution, please do ask them here or in the PR directly
@Gift-Naomi sorry, i chose the first answering :) you can look at other issues and perhaps find something for yourself

@Jemiiah
Copy link

Jemiiah commented Apr 16, 2024

@Arcticae Is there any way I can get access to the documentation, or can you be more clear on the description because the description is a little bit vague?

@Arcticae
Copy link
Contributor

Arcticae commented Apr 17, 2024

@Jemiiah we support setting #[available_gas(123)] attribute, like in regular cairo test runner. In the scope of the task is finding where to put this information, and inform the user in the docs how and when to use it (docs directory, we use mdbook).

@Arcticae
Copy link
Contributor

@Jemiiah are you working on this one? (we don't want to block others from contributing)

@Jemiiah
Copy link

Jemiiah commented Apr 29, 2024

sorry you can unsubscribe me

@Arcticae Arcticae self-assigned this Jun 25, 2024
@Arcticae Arcticae changed the title Add docs for available_gas attribute Add missing docs for attributes Jun 25, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 11, 2024
<!-- Reference any GitHub issues resolved by this PR -->

Closes #2026 
Closes #1536 

## Introduced changes

<!-- A brief description of the changes -->

- Adds a doc page for attributes briefly explaining what we support

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`

---------

Co-authored-by: kkawula <[email protected]>
Co-authored-by: Tomasz Miśkowicz <[email protected]>
Co-authored-by: ddoktorski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation snforge
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants