Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add syscalls costs to vm resources #1944

Closed
piotmag769 opened this issue Mar 28, 2024 · 3 comments
Closed

Add syscalls costs to vm resources #1944

piotmag769 opened this issue Mar 28, 2024 · 3 comments
Labels
profiler

Comments

@piotmag769
Copy link
Member

piotmag769 commented Mar 28, 2024 •
edited by MaksymilianDemitraszek
Loading

We can also consider allowing users to pass a map with syscall costs, otherwise we would take a default one.
@github-actions github-actions bot added the new label Mar 28, 2024
@MaksymilianDemitraszek MaksymilianDemitraszek removed their assignment Apr 12, 2024
@MaksymilianDemitraszek
Copy link
Member

We are postponing this to prevent conflicts. Assume that it is blocked by #1725

@piotmag769
Copy link
Member Author

Maybe we should do it only if relevant flag is passed

@piotmag769
Copy link
Member Author

piotmag769 commented Jun 3, 2024 •
edited
Loading

@MaksymilianDemitraszek merging it with software-mansion/cairo-profiler#88 in profiler board, I think doing it without software-mansion/cairo-profiler#88 will be confusing for users

@piotmag769 piotmag769 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
profiler
Projects
Starknet foundry
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MaksymilianDemitraszek @piotmag769 @drknzz