Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ByteArrays instead of felt252s in our own library assertions #1892

Closed
Arcticae opened this issue Mar 15, 2024 · 0 comments · Fixed by #1999
Closed

Use ByteArrays instead of felt252s in our own library assertions #1892

Arcticae opened this issue Mar 15, 2024 · 0 comments · Fixed by #1999
Assignees
@Draggu
Labels
new snforge
Milestone
`snforge_std` ref...

Comments

@Arcticae
Copy link
Contributor

Arcticae commented Mar 15, 2024 •
edited
Loading

Which components does the task require to be changed? (think hard pls)

snforge

Description

For example instead of .expect('') we can use longer error message and use bytearray
In order to achieve that we can use macros to panic with bytearrays
@Arcticae Arcticae added this to the `snforge_std` refactor milestone Mar 15, 2024
@github-actions github-actions bot added the new label Mar 15, 2024
@Draggu Draggu self-assigned this Apr 10, 2024
@Draggu Draggu mentioned this issue Apr 10, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Apr 10, 2024
@Draggu
Use ByteArrays instead of felt252s in our own library assertions (#…
2a26982 
…1999)

<!-- Reference any GitHub issues resolved by this PR -->

Closes #1892

## Introduced changes

<!-- A brief description of the changes -->

- Use `ByteArray`s instead of `felt252`s in our own library assertions

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Draggu Draggu

Labels
new snforge
Projects
Starknet foundry
Archived in project
Milestone
`snforge_std` refactor
Development

Successfully merging a pull request may close this issue.

Use ByteArrays instead of felt252s in our own library assertions foundry-rs/starknet-foundry
2 participants
@Arcticae @Draggu