Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp L1Handler #1891

Closed
Arcticae opened this issue Mar 15, 2024 · 0 comments · Fixed by #2097
Closed

Revamp L1Handler #1891

Arcticae opened this issue Mar 15, 2024 · 0 comments · Fixed by #2097
Assignees
@MaksymilianDemitraszek
Labels
design-doc snforge
Milestone
`snforge_std` ref...

Comments

@Arcticae
Copy link
Contributor

Which components does the task require to be changed? (think hard pls)

snforge

Description

We should remove from_address, payload from the struct params, and instead pass them to execute
@Arcticae Arcticae added this to the `snforge_std` refactor milestone Mar 15, 2024
@github-actions github-actions bot added the new label Mar 15, 2024
@Arcticae Arcticae removed the new label Apr 29, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue May 15, 2024
@MaksymilianDemitraszek
L1handler refactor (#2097)
387ec4e 
<!-- Reference any GitHub issues resolved by this PR -->

Closes #1891 

## Introduced changes

<!-- A brief description of the changes -->
- L1 refactor based on the design document

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaksymilianDemitraszek MaksymilianDemitraszek

Labels
design-doc snforge
Projects
Starknet foundry
Archived in project
Milestone
`snforge_std` refactor
Development

Successfully merging a pull request may close this issue.

L1handler refactor foundry-rs/starknet-foundry
2 participants
@MaksymilianDemitraszek @Arcticae