Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how are contracts compiled & collected #1824

Closed
Arcticae opened this issue Mar 5, 2024 · 7 comments · Fixed by #2064
Closed

Document how are contracts compiled & collected #1824

Arcticae opened this issue Mar 5, 2024 · 7 comments · Fixed by #2064
Assignees
@tomek0123456789
Labels
documentation Improvements or additions to documentation snforge

Comments

@Arcticae
Copy link
Contributor

Arcticae commented Mar 5, 2024

Which components does the task require to be changed? (think hard pls)

snforge

Description

We should describe scarb <-> forge integration more thoroughly, and specifically some information about the artifacts collection
@Arcticae Arcticae added documentation Improvements or additions to documentation snforge labels Mar 5, 2024
@github-actions github-actions bot added the new label Mar 5, 2024
@Arcticae
Copy link
Contributor Author

Arcticae commented Mar 5, 2024

@piotmag769 if you have anything that you want to add, feel free

@Arcticae Arcticae removed the new label Mar 5, 2024
@piotmag769
Copy link
Member

We can add info about declaring external (from dependencies) contracts in tests

@MaksymilianDemitraszek
Copy link
Member

Probably this could be a design doc

@piotmag769
Copy link
Member

@MaksymilianDemitraszek design doc for docs?

@MaksymilianDemitraszek
Copy link
Member

No, I mean this documentation should be a design document

@Arcticae
Copy link
Contributor Author

Users need to be able to access this and i don't see a reason not to put this inside of a guide of sorts

@MaksymilianDemitraszek
Copy link
Member

Ah ok, I thought you want a dev docs not user docs, makes sense!

@tomek0123456789 tomek0123456789 mentioned this issue Apr 24, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Apr 29, 2024
@tomek0123456789
Add contract compilation & collection docs (#2064)
b9841b5 
<!-- Reference any GitHub issues resolved by this PR -->

Closes #1824 

## Introduced changes

<!-- A brief description of the changes -->

- as in title

## Checklist

<!-- Make sure all of these are complete -->

- [ ] Linked relevant issue
- [ ] Updated relevant documentation
- [ ] Added relevant tests
- [ ] Performed self-review of the code
- [ ] Added changes to `CHANGELOG.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomek0123456789 tomek0123456789

Labels
documentation Improvements or additions to documentation snforge
Projects
Starknet foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add contract compilation & collection docs foundry-rs/starknet-foundry
4 participants
@tomek0123456789 @MaksymilianDemitraszek @Arcticae @piotmag769