Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rpc section from docs #1806

Closed
THenry14 opened this issue Mar 4, 2024 · 4 comments · Fixed by #1952
Closed

Remove rpc section from docs #1806

THenry14 opened this issue Mar 4, 2024 · 4 comments · Fixed by #1952
Assignees
@vibenedict
Labels
documentation Improvements or additions to documentation sncast

Comments

@THenry14
Copy link
Contributor

THenry14 commented Mar 4, 2024

To be consulted with snforge team, but I beliebe this https://foundry-rs.github.io/starknet-foundry/development/rpc-version.html was added to docs by mistake
@THenry14 THenry14 added documentation Improvements or additions to documentation sncast labels Mar 4, 2024
@github-actions github-actions bot added the new label Mar 4, 2024
@THenry14 THenry14 removed the new label Mar 5, 2024
@vibenedict
Copy link
Contributor

Hi, i will like this task to be assigned to me

@THenry14
Copy link
Contributor Author

Hi @vibenedict , sure - assigned

@THenry14
Copy link
Contributor Author

Hi @vibenedict !
Hope everything's going well! Just wanted to touch base regarding this issue. If you need any input, run into questions, or would like to discuss anything, feel free to reach out. We're here to support you if you run on any blockers :) cheers!

@vibenedict vibenedict mentioned this issue Mar 29, 2024
Merged
5 tasks
@vibenedict
Copy link
Contributor

Hi @THenry14, I just created the PR for this issue.

github-merge-queue bot pushed a commit that referenced this issue Mar 29, 2024
@vibenedict
docs: remove RPC version from docs (#1952)
6ac9d38 
<!-- Reference any GitHub issues resolved by this PR -->

Closes #1806

## Introduced changes

<!-- A brief description of the changes -->

- Removed RPC version section from docs

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [ ] Added changes to `CHANGELOG.md` (I noticed that changes to the
documentation are not recorded in CHANGELOG.md, so I didn't add this
change to CHANGELOG.md in order to maintain the existing pattern.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vibenedict vibenedict

Labels
documentation Improvements or additions to documentation sncast
Projects
Starknet foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: remove RPC version from docs vibenedict/starknet-foundry
2 participants
@THenry14 @vibenedict