targets: Use online root meta if not found locally #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user has not taken neither root nor targets keys offline then there are only two root versions in a given factory. In such the case, the bundle will have no any root metadata. Therefore, to make the `show` command work properly the command needs to fetch the latest (i.e. version 2) root meta from the backend. Signed-off-by: Mike Sul <[email protected]>
vkhoroz
approved these changes
Apr 16, 2024
| // then this is the valid case - a user has not taken their TUF targets key offline. | ||
| // Therefore, instead of failing the command fetches the root meta from the backend. | ||
| rootMeta, err = api.TufRootGet(viper.GetString("factory")) | ||
| } |
There was a problem hiding this comment.
Do you mean that TUF root versions 1 and 2 are never included into the update bundle?
This seems strange, but I might be out of context.
There was a problem hiding this comment.
Yes. From the security standpoint of view this the right things to do, otherwise anyone can generate their own chain of TUF keys and put into a bundle. Then, a non-registered device will trust it.
However, we protect our devices from it by pre-provisioning them with the first N root versions...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user has not taken either root or target keys offline, then there are only two root versions in a given factory.
In such a case, the bundle will have no root metadata.
Therefore, to make the 'show' command work properly, the command needs to fetch the latest (i.e., version 2) root metadata from the backend.