Support filtering waves by status and tag #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Volodymyr Khoroz <[email protected]>
Signed-off-by: Volodymyr Khoroz <[email protected]>
doanac
reviewed
Jan 2, 2024
| @@ -18,17 +18,17 @@ func init() { | |||
| cmd.AddCommand(listCmd) | |||
| listCmd.Flags().Uint64P("limit", "n", 20, "Limit the number of results displayed.") | |||
| listCmd.Flags().Uint64P("page", "p", 1, "Page of waves to display when pagination is needed") | |||
| listCmd.Flags().BoolP("only-active", "", false, "Only show currently active waves") | |||
| listCmd.Flags().StringP("status", "S", "", "Only show waves with a given status; one of (active, complete, canceled)") | |||
There was a problem hiding this comment.
I noticed we aren't super graceful when handling a bad status flag:
$ fioctl waves list --status foo
ERROR: HTTP error during GET 'https://api.foundries.io/ota/factories/andy-corp/waves/?limit=20&page=1&status=foo': 400 BAD REQUEST
= Input payload validation failed
* status: Filter waves by status The value 'foo' is not a valid choice for 'status'.
I seem to remember Cobra doesn't really do enums so this might be about the best we can do w/o adding a bunch of code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.