Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support docker-credential-helper using absolute path #345

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Support docker-credential-helper using absolute path #345

merged 1 commit into from
Dec 14, 2023

Conversation

vkhoroz
Copy link
Member

@vkhoroz vkhoroz commented Dec 14, 2023

No description provided.

@vkhoroz vkhoroz self-assigned this Dec 14, 2023
doanac
doanac reviewed Dec 14, 2023
View reviewed changes
cmd/root.go Show resolved Hide resolved
mike-sul
mike-sul approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@mike-sul mike-sul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me, not sure how though.

@vkhoroz vkhoroz merged commit 5f3f25b into main Dec 14, 2023
8 checks passed
@vkhoroz vkhoroz deleted the vkhoroz-docker-credential-helper branch December 14, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doanac doanac doanac left review comments

@mike-sul mike-sul mike-sul approved these changes

@StealthyCoder StealthyCoder Awaiting requested review from StealthyCoder

Assignees

@vkhoroz vkhoroz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vkhoroz @doanac @mike-sul