Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<raw> tags don't support multi-line html #109

Open
SampsonCrowley opened this issue May 6, 2019 · 4 comments · May be fixed by #110
Open

<raw> tags don't support multi-line html #109

SampsonCrowley opened this issue May 6, 2019 · 4 comments · May be fixed by #110

Comments

@SampsonCrowley
Copy link

SampsonCrowley commented May 6, 2019 •
edited
Loading

since this is an HTML based library, I found this functionality to be extremely surprising. I will submit a PR to fix as soon as I can

input

<body>
  <raw>
    <<LCG ProgramTG LCG Coupon Code Default='246996'>>
    <button>
  </raw>
</body>

expected

<body>
    <<LCG ProgramTG LCG Coupon Code Default='246996'>>
    <button>
</body>

output

<body>
  <raw>
    <<lcg programtg lcg coupon code default="246996">>
      <table class="button">
        <tbody>
          <tr>
            <td>
              <table>
                <tbody>
                  <tr>
                    <td>
                      </td>
                  </tr>
                </tbody>
              </table>
            </td>
          </tr>
        </tbody>
      </table>
      </lcg>
  </raw>
</body>
@SampsonCrowley
Copy link
Author

@tdhartwick what should I do if the current develop branch already has failing tests before I even start working? just ignore them and keep the pull request under SRP (only one feature change per request?)

@SampsonCrowley SampsonCrowley linked a pull request May 6, 2019 that will close this issue
Open
@SampsonCrowley
Copy link
Author

@marcandre which branch should I actually be targeting here? v2 is the most recently updated, develop is the most recent not v* branch, and master hasn't been updated for 3 years

@marcandre
Copy link
Contributor

You should target develop. Note that I'm not a committer on inky; I'm not sure who the current maintainers are.

@SampsonCrowley
Copy link
Author

My mistake; I thought I had seen your name on a merge in this repo as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix raw tag parsing for multiple lines SampsonCrowley/inky
2 participants
@marcandre @SampsonCrowley