Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to support other than rails? #5

Open
sjoonk opened this issue Jul 1, 2016 · 9 comments
Open

Any plan to support other than rails? #5

sjoonk opened this issue Jul 1, 2016 · 9 comments

Comments

@sjoonk
Copy link

sjoonk commented Jul 1, 2016

It seems this gem run only rails env. Do you have any plan to support other than rails like Sinatra, etc.?

@shreve
Copy link

shreve commented Jul 4, 2016

This seems like it would be pretty easy to do. I've never created a Tilt-compliant template engine before.
Sinatra's relevant docs.

@kball
Copy link
Contributor

kball commented Jul 26, 2016

@sjoonk @shreve We'd happily accept a PR to do so, otherwise it may be a little while before we get this to happen.

@oyeanuj
Copy link

oyeanuj commented Sep 9, 2016

@kball Somewhat related followup - within rails, does it support Rails-API (4 or 5) only projects? Or does it make certain assumptions that one should be aware of?

@redroot
Copy link

redroot commented Sep 9, 2016

@oyeanuj I use it in a Rails API 5 project, the only possibly related change i had to make was to re-add support for the asset-pipeline, but I think thats to do with gem 'foundation_emails' that uses inky-rb in reality. Something to be aware of at least.

@oyeanuj
Copy link

oyeanuj commented Sep 22, 2016

@redroot thanks for your response. So did you just add sprocket-rails gem? I am having trouble with getting it to work. Do you, by any chance, remember the steps/configuration/gems you added to get this to work?

@redroot
Copy link

redroot commented Sep 22, 2016

@oyeanuj I had to uncomment / add this line at the top of application.rb near the other railties: require "sprockets/railtie" and add a new initializer called assets.rb
with the following

# Be sure to restart your server when you modify this file.

 # Version of your assets, change this if you want to expire all your assets.
 Rails.application.config.assets.version = '1.0'

@marcandre
Copy link
Collaborator

FWIW, I've added automatic tests for Rails 3, 4 & 5. I didn't have anything special to do to make it work with either versions once my config was working with all versions.

@ryanwi
Copy link

ryanwi commented Nov 10, 2016

I'm starting to look at how to use inky in a non-web environment too, in this case a rabbitmq consuming service that sends email. It only uses actionmailer from the Rails stack. I've got the templating somewhat working by pulling the TemplateHandler class into the app, but not the inlining.

@marcandre
Copy link
Collaborator

@ryanwi As per the doc, for the CSS inlining use either premailer or roadie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants