fix(lint): Fixed golang linting errors #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvjsharma
force-pushed
the
feat/issue-37
branch
2 times, most recently
from
ad17bb4
to
60b1fd2
Compare
|
Hi @GMishx, |
dvjsharma
force-pushed
the
feat/issue-37
branch
from
60b1fd2
to
b08411a
Compare
|
@dvjsharma , the repo requires signed commits. Maybe you can look into it and follow it from next PR :-) |
Ahh so sorry, will keep in mind 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes all the errors and warnings cached by
golangci-lint, hence making the codebase clean and ready to deploy golang static checks and linting action as mentioned in #36closes #37
merge before #36
CC @GMishx