Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text and number input properties not working #935

Open
tripp528 opened this issue May 29, 2024 · 1 comment · May be fixed by #936
Open

Text and number input properties not working #935

tripp528 opened this issue May 29, 2024 · 1 comment · May be fixed by #936

Comments

@tripp528
Copy link

tripp528 commented May 29, 2024 •
edited
Loading

Bug Description
When using a text or number property, upon trying to change the initial value, the event that's fired only contains the old value.

Reproduction Steps

  1. Create a properties window in any environment with a text input i.e.
    [
    {'type': 'text', 'name': 'Test', 'value': 'Testing...'},
    ]

  2. Register a callback on that window to print every event.

  3. Try to type another letter at the end of the text box that says 'Testing...'

  4. Observe the 'PropertyUpdate' event that is printed. event['value'] is still 'Testing...'.

Expected behavior
The event['value'] should be 'Testing...<typed letter>'
@tripp528
Copy link
Author

Ah, it seems that this only happens when I have an image window with a keypress handler. The event is being published globally, and as such, the keypress preventDefault() in the ImagePane was being called even if that event was targeted toward a different pane.

@tripp528 tripp528 linked a pull request May 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@tripp528