Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed VL53L0X #2535

Merged
merged 1 commit into from
Aug 11, 2024
Merged

fix: fixed VL53L0X #2535

merged 1 commit into from
Aug 11, 2024

Conversation

AsCress
Copy link
Contributor

@AsCress AsCress commented Aug 11, 2024

Fixes a bug in the communication class for the VL53L0X sensor (VL53L0X.java).
This didn't affect the functioning of the sensor but caused the sensor readings to fail if it was used more than once after connecting the PSLab.

Changes

  • Fixes a configuration issue wherein an empty array was being written to the sensor registers.

Screenshots / Recordings

N/A

Checklist:

  • No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

Summary by Sourcery

Fix configuration issue in VL53L0X sensor communication class to ensure proper sensor readings when used multiple times after connecting the PSLab.

Bug Fixes:

  • Fix configuration issue in VL53L0X sensor communication class to prevent sensor readings from failing when used multiple times after connecting the PSLab.

Copy link

sourcery-ai bot commented Aug 11, 2024

@AsCress AsCress added the Fix Solution to an existing issue in app label Aug 11, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AsCress - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Good catch on the empty array issue. Consider adding a brief comment explaining the purpose of these specific register writes for future maintainers.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@marcnause marcnause merged commit 4e0cf82 into fossasia:development Aug 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Solution to an existing issue in app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants