Fixed About page crash issue #2084
Conversation
|
I tired fixing the darktheme but the android-about-page repo's last production build is more than a year old and there is almost no way this can be fixed other than fiddling with the jar files 😅, ( I did find something here medyo/android-about-page#113) ... also the issue was about crash and switching of theme on the fly so I left the dark theme as it is 😇 |
|
I will try to fix that in next pr if possible.. now that I got some leads into how to do it |
|
I already worked on dark mode system which is much more flexible than all these things and is kind of future proof considering its considered under https://developer.android.com/jetpack/androidx .. and doesn't rely on android support libraries (which will soon be unsupported) #2065 but that doesn't seem to be our priority now 😅 so I left it. Just mentioning as this is related |
|
@CloudyPadmal @cweitat please review this 😄 |
|
LGTM! |
|
can this be merged? |
|
@CloudyPadmal Done the changes 😇 |
|
@CloudyPadmal RTM |
|
@Sid911 Please resolve conflicts. |
CloudyPadmal
added
the
Status: Conflicts
Fixes #2083
Changes:
App Compat Day Nightas a parent style which directly takes the information from system variable to change the theme actively. The functionsimulateDayNightcounters that by forcing the app theme to change back to light. This creates a loop you can see in bottom gif, in android 10 of my testing in avd even shows more frequent crashes.Screenshot/s for the changes:
Before :
Now:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]APK for testing: [Compress the
app-debug.apkfile into a<feature>.raror<feature>.zipfile and upload it here]aboutPageCrash.zip