Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: landscape orientation of statistics #620

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

fix: landscape orientation of statistics #620

wants to merge 1 commit into from

Conversation

rob729
Copy link
Contributor

@rob729 rob729 commented Feb 1, 2020

Fixes #619

Screenshot/s for the changes:

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

@auto-label auto-label bot added the fix Solution to a bug or an issue label Feb 1, 2020
@rob729
Copy link
Contributor Author

rob729 commented Feb 1, 2020

@jddeep @iamareebjamal @adityastic Please review this PR.

jddeep
jddeep suggested changes Jun 5, 2020
View reviewed changes
Copy link
Member

@jddeep jddeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rob729 Could you add a working Gif here? I am seeing too many changes in the layout. A simple parent layout replaced with ScrollView could do the job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jddeep jddeep jddeep requested changes

@adityastic adityastic Awaiting requested review from adityastic

@CloudyPadmal CloudyPadmal Awaiting requested review from CloudyPadmal

@iamareebjamal iamareebjamal Awaiting requested review from iamareebjamal

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
fix Solution to a bug or an issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contents not visible properly in statistics screen in landscape orientation
2 participants
@rob729 @jddeep