From dc72baa2e376fa1d4d7b15be71f44893bdb412c1 Mon Sep 17 00:00:00 2001 From: kzeer Date: Fri, 19 Nov 2021 11:59:55 -0500 Subject: [PATCH] resolved issue #273 game over without touching any object by modifying flapping.js isOverlap to add half of width/height to midpoint --- javascript/flapping.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/javascript/flapping.js b/javascript/flapping.js index 3822beb..3afd44f 100644 --- a/javascript/flapping.js +++ b/javascript/flapping.js @@ -148,10 +148,10 @@ function getCenteredrect(rect){ function isOverlap(e1, e2) { rect1 = getCenteredrect(e1); rect2 = getCenteredrect(e2); - if (rect1.x < rect2.x + rect2.width && - rect1.x + rect1.width > rect2.x && - rect1.y < rect2.y + rect2.height && - rect1.height + rect1.y > rect2.y) + if (rect1.x < rect2.x + rect2.width/2 && + rect1.x + rect1.width/2 > rect2.x && + rect1.y < rect2.y + rect2.height/2 && + rect1.height/2 + rect1.y > rect2.y) return true; else return false; }