Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autoplay switch button from room settings UI #196

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

untari
Copy link
Contributor

@untari untari commented Aug 5, 2024

This PR addresses the issue discussed here: #188 (comment)

It removes the autoplay switch button from the room settings. Livestream videos will autoplay by default, and this setting can be adjusted in the user profile settings. By eliminating the redundant autoplay switch, this update simplifies the user interface and reduces confusion.

Summary by Sourcery

Remove the autoplay switch button from the room settings UI, making livestream videos autoplay by default and allowing this setting to be adjusted in the user profile settings.

Enhancements:

  • Remove the autoplay switch button from the room settings UI to simplify the interface and reduce user confusion.

Copy link

sourcery-ai bot commented Aug 5, 2024

Reviewer's Guide by Sourcery

This pull request removes the autoplay switch button from the room settings UI. The changes include deleting the 'autoStart' bunt-switch component and its associated computed property in 'stage.vue', as well as removing the 'autoStart' parameter from the 'getYoutubeUrl' method in 'MediaSource.vue'. This update simplifies the user interface by eliminating a redundant setting, as autoplay can now be managed through user profile settings.

File-Level Changes

Files Changes
webapp/src/views/admin/rooms/types-edit/stage.vue
webapp/src/components/MediaSource.vue
Removed the 'autoStart' setting from both the room settings UI and the YouTube URL generation logic.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @untari - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, makes sense, but I am unclear if this actually works with the global button. Need to check.

@mariobehling mariobehling merged commit fc39d6f into fossasia:development Aug 5, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants