Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement audio translation system #147

Merged
merged 19 commits into from
Jul 14, 2024
Merged

Implement audio translation system #147

merged 19 commits into from
Jul 14, 2024

Conversation

odkhang
Copy link
Collaborator

@odkhang odkhang commented Jul 8, 2024

Fixes #203 Implement translation system as in previous eventyay version

Short description of what this resolves:

Implement translation system as in previous eventyay version

Changes proposed in this pull request:

  • Implement translation system as in previous eventyay version

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

untari and others added 13 commits June 26, 2024 23:32
@odkhang odkhang marked this pull request as draft July 8, 2024 02:43
@odkhang
Copy link
Collaborator Author

odkhang commented Jul 8, 2024

Add translation youtube url

image

audio translation dropdown

image

@odkhang odkhang marked this pull request as ready for review July 8, 2024 03:14
@odkhang odkhang requested a review from mariobehling July 8, 2024 03:14
@mariobehling
Copy link
Member

Merging this for in-depth testing in dev deployment.

@mariobehling mariobehling merged commit 2b36d62 into fossasia:development Jul 14, 2024
1 of 2 checks passed
@mariobehling mariobehling changed the title Implement translation system as in previous eventyay version Implement audio translation system Jul 14, 2024
@mariobehling
Copy link
Member

This is the first step of the feature.

The functionality should work in the way that the video source always stays the same no matter what language is choosen. But: When the user clicks on another language the audio source changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariobehling mariobehling mariobehling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement translation system as in previous eventyay version
3 participants
@odkhang @mariobehling @untari