Add Video-Component Logic to User's Dashboard #314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request implements the Eventyay-video-component in the User Dashboard. It adds a new Components view, updates the authentication base template, and modifies related Python files to support the new functionality. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @AviGawande - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider catching more specific exceptions in ComponentsView instead of a general Exception to avoid masking potential issues.
- The template for Eventyay-Talk and Eventyay-Video components contains similar code. Consider refactoring this into a reusable template snippet to reduce duplication.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
|
The approach to providing access to the video component extends beyond the dashboard and requires a more comprehensive solution. A draft PR addressing this issue with a different method is available here: PR #376. Therefore, I am closing this PR in favor of that approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #301 for implementing the Eventyay-video-component to User Dashboard.
Summary by Sourcery
Add a new 'Components' view to the user dashboard, allowing users to check the installation status of Eventyay-Talk and Eventyay-Video components. Refactor the HTML template structure for better maintainability.
New Features:
Enhancements: