Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add co-speaker feature broken #129

Open
mariobehling opened this issue Jul 18, 2024 · 4 comments
Open

Add co-speaker feature broken #129

mariobehling opened this issue Jul 18, 2024 · 4 comments

Comments

@mariobehling
Copy link
Member

mariobehling commented Jul 18, 2024

When an organiser activates "additional speaker" in the content section the form for speakers shows two areas to enter a speaker email.

a) The top form field works as expected.
b) When the speaker adds an email in the second form field nothing happens after saving the form.

This is confusing. Why are there two areas?

However in contrast to eventyay-talk on Pretalx this seems to work. Identify the difference and fix the issue to work in the same way as Pretalx.

Organiser content form
Screenshot from 2024-07-19 00-52-50

Speaker form
Screenshot from 2024-07-19 00-49-04

Tested on https://wikimania-dev.eventyay.com/

@odkhang
Copy link
Collaborator

odkhang commented Jul 19, 2024

Hi @mariobehling ,

I have checked Pretalx and see it work the same as eventyay-talk

  1. As the first page when you submit a proposal, and fill in 'Additional Speaker', invitation will be send without any issue

image

  1. But in the edit proposal, it correct as you mentioned, additional Speaker not work.

=> the addtional Speaker only work once when we submit proposal

To prevent the confusing, there're 2 options:

  1. Remove 'Additional Speaker' as we can use this
    image

  2. Send invitation for 'Additional Speaker' if it added

@mariobehling
Copy link
Member Author

@odkhang @lcduong Yes, I think option 2 would make sense the most for the moment: Send invitation for 'Additional Speaker' if it added

@lcduong
Copy link
Contributor

lcduong commented Jul 19, 2024

sure @mariobehling, please help me to review this PR: #130

@mariobehling
Copy link
Member Author

When the speaker field invites a speaker the log message for the session should show "A speaker was invited to the proposal."

Currently the log message is as follows:

Screenshot from 2024-07-20 18-20-36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants