chore: Add Branch Deletion to GitHub Actions Pipeline for Issue #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis PR streamlines the GitHub Actions workflow by implementing automatic branch deletion and simplifying the build process. The changes focus on optimizing the version update process, simplifying artifact handling, and adding a new job to clean up the APK branch after builds. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ayushontop - I've reviewed your changes - here's some feedback:
Overall Comments:
- The PR title and description focus on branch deletion but include significant unrelated changes. Please update the title and description to accurately reflect all changes being made.
- The removal of the iOS build and screenshots jobs needs to be explained in the PR description. If these are intentional changes, please provide the rationale.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Hi @adityastic can you please review this PR, Thanks, please let me know if there are any changes to be made |
|
Hey 👋, I don't think we need to remove the apk branch. What is the concern atm? Once we update HEAD by force pushing, the tree ref would not point to the last commits meaning those commits won't be pulled while fetching or updating apk branch in your local repo anyway |
|
Feel free to comment and let's discuss if we need to reopen this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements automatic branch deletion as part of the GitHub Actions pipeline to address issue #743 This feature ensures that the specified branch is deleted after each successful build or release, helping to keep the repository clean and preventing repository size increase over time.
Feature Overview:
Branch Deletion:
Deletes the specified branch after each run to avoid clutter and manage repository size effectively.
Configured to run as a final job in the workflow.
Related Issue:
Closes #743
Summary by Sourcery
CI: