config: Fix Wallabag version type #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The frontend compared the Wallabag version with a number using strict comparison since 16f1cd6. But when we switched to a custom configuration container in 1f194f8 (part to 2.19), we accidentally made the version a string breaking sharing to Wallabag. Bumping the API version since changes the type of field in `/api/about` endpoint, even though the fields are explicitly not part of the API promise.
✅ Deploy Preview for selfoss ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frontend compared the Wallabag version with a number using strict comparison since 16f1cd6.
But when we switched to a custom configuration container in 1f194f8 (part to 2.19),
we accidentally made the version a string breaking sharing to Wallabag.
Bumping the API version since changes the type of field in
/api/aboutendpoint, even though the fields are explicitly not part of the API promise.