Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand selection only go up the DOM tree #60

Open
longpt214 opened this issue May 28, 2018 · 0 comments
Open

Expand selection only go up the DOM tree #60

longpt214 opened this issue May 28, 2018 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@longpt214
Copy link
Contributor

The selection expansion button supposes to visually expand the selection. However, currently it only goes up the DOM tree. As sometimes the DOM parent node has smaller size than the children, when expanding the selection, it actually shrinks the selection visually and sometimes makes the selection disappear. Suggested solution: When moving up the DOM node, we should skip the one that has the size (width and height) smaller than the current node.

Can repeat/test the issue with Amazon. Click on a price, and the move up by clicking on the plus button. Do that several times and you will see the issue I described above. See attached image.

image

@longpt214 longpt214 added the bug Something isn't working label May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants