Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FHeaderAction & replace it with FButton.icon() (context-aware styling) #233

Open
Pante opened this issue Oct 20, 2024 · 0 comments
Open
Labels
difficulty: hard priority: low Features/Improvements that we "want" but not "need" type: ehancement A new feature or request

Comments

@Pante
Copy link
Member

Pante commented Oct 20, 2024

Is your feature request related to a problem? Please describe.
FHeaderAction is almost identical to FButton.icon(). It would be great if there was a way to simplify the public API by removing FHeaderAction and allow users to just use FButton.icon() instead. However, the default style for header actions is different from buttons. We'll end up with FHeader's icon style -> FButton.icon() -> FButton's icon style, therefore making it impossible to override the icon style with our current system.

We need "context-aware styling". However, it remains unknown if the benefits of it outweigh the cons. Specifically, the results of placing widgets under certain parents might prove to be counter-intuitive. Does that outweigh the benefit of creating wrapper types just to provide a different default style?

@Pante Pante added difficulty: hard priority: low Features/Improvements that we "want" but not "need" type: ehancement A new feature or request labels Oct 20, 2024
@Pante Pante changed the title Remove FHeaderAction & replace it with FButton.icon(). Remove FHeaderAction & replace it with FButton.icon() (context-aware styling) Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: hard priority: low Features/Improvements that we "want" but not "need" type: ehancement A new feature or request
Projects
None yet
Development

No branches or pull requests

1 participant