Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix lookup and automatic installation of fortls on Windows #772

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix lookup and automatic installation of fortls on Windows #772

wants to merge 7 commits into from

Commits on Dec 10, 2022

  1. add check for python

    @michaelkonecny
    michaelkonecny committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    68f4b3b View commit details
    Browse the repository at this point in the history

  2. feat: look for fortls in the user Scripts folder on Windows 

    pip installs fortls in the %appdata%\Roaming\Python\Python311\Scripts\
folder, which is typically not in PATH, so the extension wouldn't find
fortls after installing it.
Now it also looks for fortls in this folder.

Other changes:
- The user configured path to fortls must now be absolute.
  This simplified a lot of things and it doesn't make sense to me to
  have multiple versions of fortls on the system, per workspace.
  Please let me know if this is not OK.
- The fortls.disabled config value now gets stored in the USER settings
  instead of workspace. Similar reasons as above, it seems easier to
  find.
    @michaelkonecny
    michaelkonecny committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    8e86d44 View commit details
    Browse the repository at this point in the history

  3. change default value of fortran.fortls.path to an empty string

    @michaelkonecny
    michaelkonecny committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    8af551b View commit details
    Browse the repository at this point in the history

  4. add error message when fortls spawn fails from user defined path

    @michaelkonecny
    michaelkonecny committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    b3d1766 View commit details
    Browse the repository at this point in the history

  5. fix prettier call 

    fixes pre-commit hook failing with the following message:
```
npm run format:
[error] No files matching the pattern were found: "'src/**/*.{ts,json}'".
[error] No files matching the pattern were found: "'test/**/*.ts'".
[error] No files matching the pattern were found: "'syntaxes/**/*.json'".
[error] No files matching the pattern were found: "'snippets/**/*.json'".
[error] No files matching the pattern were found: "'./**/*.{md,json,yaml,yml}'".
```
    @michaelkonecny
    michaelkonecny committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    b268e0b View commit details
    Browse the repository at this point in the history

  6. prettier: add --end-of-line auto argument to maintain sanity on Windows

    @michaelkonecny
    michaelkonecny committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    066ca08 View commit details
    Browse the repository at this point in the history

  7. formatting after prettier managed to run

    @michaelkonecny
    michaelkonecny committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    1747802 View commit details
    Browse the repository at this point in the history