Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation errors not showing up for type day #572

Open
federico-ntr opened this issue Jul 30, 2024 · 2 comments
Open

Validation errors not showing up for type day #572

federico-ntr opened this issue Jul 30, 2024 · 2 comments

Comments

@federico-ntr
Copy link

I have a form with two components, one of type day, with day, month and year required, and one of type textfield, required. Both have a custom error message.

Both while typing and on submission, errors are not shown for the day component. I tried calling the submit function and I noticed the error is actually thrown. It seems like the library is not adding the correct class to the element in order for the error to be shown.

To Reproduce
Steps to reproduce the behavior:

  1. Go to repro: https://codesandbox.io/p/sandbox/modest-worker-mtztn2
  2. Click on "verify"
  3. See that error on day is not shown
  4. Click on "vertify with workaround"
  5. See that error on day is now shown thanks to the ugly workaround I implemented

Expected behavior
Errors on day component should be shown both while typing and on submit

Screenshots
Without workaround:
image
With workaround:
image

Desktop (please complete the following information):

  • OS: Tested on Windows 10 and macOS 14.5
  • Browser chromium based
  • Version 127.0.6533.73

Additional context
The version of the libs in the repro are the exact ones I use in my project

@daneformio
Copy link

I've created a ticket for our development team to review. If you would like to submit a pull request we would review it as a potential fix.
Ticket for internal tracking: FIO-8867

@lane-formio
Copy link
Contributor

After review, we don't expect to resource a developer to investigate this in the near future but would be happy to review any contributions to resolve this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants