Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Detect and prevent newly-added imports #8

Open
sciwhiz12 opened this issue Mar 4, 2021 · 0 comments
Open

Detect and prevent newly-added imports #8

sciwhiz12 opened this issue Mar 4, 2021 · 0 comments
Labels
enhancement This requests or implements a new feature or enhancement.

Comments

@sciwhiz12
Copy link
Contributor

Javadocs also respect imports, and sometimes IDEs like to automatically add imports when referencing external classes. This poses a problem when a javadoc comment written in the workspace references a class via a newly-added import, because that import does not get saved, and the reference will error upon a fresh setup.

This problem is difficult to detect during review, because you'd need to have a workspace open to see all the imports. So, we need to find a solution to detect these newly-added imports, and fail a verification check if it finds them.

Preliminary thoughts: We'll need to persist the import info somehow; two possible ways are saving list of imports to a file and comparing, or comparing between the workspace version and the source from the sources JAR.

@sciwhiz12 sciwhiz12 added the enhancement This requests or implements a new feature or enhancement. label Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement This requests or implements a new feature or enhancement.
Projects
None yet
Development

No branches or pull requests

1 participant