Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve placeholders in server instead of in client #43

Open
stephanspiegel opened this issue Oct 4, 2022 · 0 comments
Open

Resolve placeholders in server instead of in client #43

stephanspiegel opened this issue Oct 4, 2022 · 0 comments

Comments

@stephanspiegel
Copy link

Is your feature request related to a problem? Please describe.
Currently, the SOQL language server produces various placeholders during completion:

__SOBJECTS_PLACEHOLDER
__SOBJECT_FIELDS_PLACEHOLDER
__RELATIONSHIPS_PLACEHOLDER
__RELATIONSHIP_FIELDS_PLACEHOLDER
__LITERAL_VALUES_FOR_FIELD

It's then up to the LSP client to resolve the placeholder into the appropriate SObject names, field names, etc. for the users' current org.

This means any editor (besides VS Code) wanting to use the SOQL LSP server has to re-implement this placeholder resolution.

Describe the solution you'd like
Move the action of resolving placeholders from the LSP client into the LSP server.

Describe alternatives you've considered
The alternative is for each editor (client) to re-implement this functionality, which is counter to the point of having an LSP in the first place.

Additional context
I've successfully set up this language server using neovim as a client, but not being able to get completion for SObjects and fields limits its usefulness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant