-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to deploy output? #3079
Comments
Hello @gdman 👋 It looks like you didn't include the full Salesforce CLI version information in your issue. A few more things to check:
Thank you! |
Thank you for filing this issue. We appreciate your feedback and will review the issue as soon as possible. Remember, however, that GitHub isn't a mechanism for receiving support under any agreement or SLA. If you require immediate assistance, contact Salesforce Customer Support. |
I'd like to also add the feedback that while this change is nice in a normal terminal's output, it makes my CI output completely unreadable and the page is a mile long. I was hoping that |
This issue has been linked to a new work item: W-17060727 |
@smithmd and @gdman - Thank you for your feedback. We're working on a fix now. Once fixed, the CI output will look like this:
And will follow these rules:
Feedback or questions?Please let us know if you think the proposed fixes will work or if we've missed anything. Thank you! |
That sounds great to me. Thanks for the fast response! |
I had one thought overnight. How are component/test failures handled? Is there immediate feedback in the build output or does the user need to wait until the end? There have been a few iterations of deploy logging over the years, some have provided instant logging of a component or test failure, whereas others say there is an error but not what it is or nothing until the end. Deploy processes can be long - test runs can take hours, the sooner the developer knows about any failure the better. For context, the developers don't necessarily have access to the org where a build is being validated so the only thing they have to go on is the logs. |
@VivekMChawla Regarding this particular change, after upgrading to latest cli version I got ~2 million records of output in my CI/CD logs for metadata retrieve, validate and deploy jobs. In some cases browser tab is simply crashing when I try to open jobs with such big logs. Moreover, we've found that some of our pretty heavy metadata retrieve jobs for big orgs are simply crashing due to heap out of memory errors - I got all this trouble just becuase of this "better" output, I've not been asking for) |
+1, we've also unexpectedly ended up with |
@avesolovksyy - The fix described in my previous message will result in fewer output lines in CI/CD logs. I apologize for the manner in which this feature was delivered. The fix should be in the We are also investigating the root cause of the @pgumiela-wbd - Regarding your
Getting out a fix for this is my top priority. Thank you both for your patience. |
Hello @VivekMChawla , we also started to experience Command: Single output is pretty long and it is repeated each 5 seconds. |
@janmaj-ibm @pgumiela-wbd @avesolovksyy @gdman @smithmd Apologies for the inconvenience this caused you. We decided to downgrade Going forward, I have two PRs that address the issues/concerns you all brought up. oclif/multi-stage-output#52 will implement the changes that @VivekMChawla described in this comment. oclif/table#32 will address the out of memory issue that a couple of you are experiencing. Those changes will go into our nightly build as soon as they're reviewed and tested, which will likely happen in the next couple of days. I will post back here once they're available in |
yup, we are also experiencing the heap limit issue in CI now as well |
The latest nightly (2.65.8) now has all the changes we described above |
We hit an issue with some code which called out to execSync(`sf project deploy start --source-dir ${tempDeployDir}`); We didn't even do anything with the output from the process, just check the exit code. Presumably because the code was run from a tty, the timer was updating very frequently under the assumption someone would immediately see the clock updating. As I said previously, we never used the output from the command, and so eventually the buffer just overflows, as there was a huge amount of data being sent via STDOUT which eventually crashed out our code like so (I have truncated the log):
|
@geoffswift - Thank you for sharing the output of your logs. What you shared is extremely helpful. Two quick questions:
FYI: @mdonnalley |
The problem I reported was indeed on someone's local machine. I did use |
Summary
Have there been recent changes to the deploy console output again?
Since the most recent build the output is much less clear than it was in the previous version.
Before - clear output that says how many components and tests:
After - output that probably looks nice and pretty in an interactive terminal but is much worse in CI output (where deploy is most commonly run):
Version: 2.63.7
The text was updated successfully, but these errors were encountered: