Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fitting equidistant frequency points (as compared to other spacing) #76

Closed
TomDonoghue opened this issue Mar 18, 2018 · 1 comment
Closed

Comments

@TomDonoghue
Copy link
Member

As brought up by @rdgao :

Inputs PSDs currently require linearly spaced frequency points. This is not necessarily ideal, at least when thinking about fitting much broader frequency ranges.

Notes from Richard:
Fitting the Lorentzian (no knee) in semilog is mathematically equivalent to fitting a line in log-log (it still uses every frequency point). The specific issue is not from fitting in log-log, but in using linearly-spaced frequency points. The error between 10-20Hz weighs just as much as the error between 80-90Hz, which is potentially undesirable, given our a priori knowledge about brain PSDs.

For future version of FOOOF, we should consider:

  • Is there anything fundamental about using linearly spaced frequencies? How can we, and should we think about moving to supporting different frequency scales. [As of right now, the algorithm definitely presumes even-spaced - it's an open question how fundamental this is].
  • When and how do we want to accept, or even encourage different frequency spacing.
@TomDonoghue
Copy link
Member Author

Following #154, this has been moved to:
fooof-tools/Development#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant